help ..... plz plz help me!!!

Comments

• KevinADC

  November 2005

  change these two lines:
  
  my @temp_array = ($user_ip);
  @temp_array = split(/./, $_);
  
  to:
  
  my @temp_array = split(/./,$user_ip);
  
  and see if that helps.
  
  
• White_Shadow

  November 2005

  [b][red]This message was edited by White_Shadow at 2005-11-12 0:32:41[/red][/b][hr]
  : change these two lines:
  :
  : my @temp_array = ($user_ip);
  : @temp_array = split(/./, $_);
  :
  : to:
  :
  : my @temp_array = split(/./,$user_ip);
  :
  : and see if that helps.
  :
  :
  
  no mate it still doesnt do it right. the program works, it just when u run it, it always says its not valid something to do with the way the IF statements are place or work i think!!! THANKS FOR THE INPUT ANYWAY!!!
  
  
  
• rsmanu

  November 2005

  [b][red]This message was edited by rsmanu at 2005-11-12 10:34:37[/red][/b][hr]
  Hi friend,
  
  Read the question posted by you. With my knowledge of the question I am posting this solution that I could get.
  
  ######################################################################
  
  #! /usr/bin/perl
  
  use warnings;
  use strict;
  
  my @ipoctets = split /./, shift;
  
  if ($ipoctets[0] < 1 or $ipoctets[0] > 255) {
  print "Invalid IP Address.
  ";
  exit;
  }
  
  for (1 .. 3) {
  if ($ipoctets[$_] < 0 or $ipoctets[$_] > 255) {
  print "Invalid IP Address.
  ";
  exit;
  }
  }
  
  print "
  The IP Address entered is valid.";
  
  #######################################################################
  
  Try out thhis program and check whether it suits your requirements.
  
  Good Luck.
  
  rsmanu.
  
  
  
• White_Shadow

  November 2005

  [b][red]This message was edited by White_Shadow at 2005-11-12 17:42:8[/red][/b][hr]
  hey dude thanks,
  
  i would use it but we havent done some of that stuff in class yet so it might look a bit sus! but thanks again ill try it out and see if it works. i finially got mine working anyway but its messy then yours and alot more lines. (hey but it works!!) well the only thing i cant do is put it through the @ARGV thing it jus dont work ill keep at it but if you know how this @ARGV works give me a shout!!
  
  Thanks for ya help
  
  heres my script with everything working bar the @ARGV
  
  #james mcgill
  #november 2005
  #assignment 2 question 1 check_ip
  #this program will test and check if the users ip they have entered is a valid ip address.
  
  
  
  use strict;
  
  my $user_ip;
  my $first_octet;
  my $second_octet;
  my $third_octet;
  my $fourth_octet;
  my $ip_test = "true";
  my $num_msg;
  my $letter_msg;
  
  
  system ("cls");
  
  print "
  Please enter an IP address you wish to check.
  --> ";
  $user_ip = ;
  chomp ($user_ip);
  
  if ($user_ip !~ /D [^0-9]/) {
  $ip_test = "false";
  $letter_msg = "The IP address contained a letter, IP addresses can only be numbers.";
  }
  
  
  my @ip_address = ($user_ip);
  
  
  foreach (@ip_address){
  
  my @temp_array = split(/./, $_ );
  $first_octet = @temp_array [0];
  $second_octet = @temp_array [1];
  $third_octet = @temp_array [2];
  $fourth_octet = @temp_array [3];
  
  
  
  if ($fourth_octet < 0 <=> $fourth_octet >= 256) {
  $ip_test = "false";
  $num_msg = "It failed on the fourth octet, octet four must be between 0 and 255.";
  }
  
  if ($third_octet < 0 <=> $third_octet >= 256) {
  $ip_test = "false";
  $num_msg = "It failed on the third octet, octet Three must be between 0 and 255.";
  }
  
  if ($second_octet < 0 <=> $second_octet >= 256) {
  $ip_test = "false";
  $num_msg = "It failed on the second octet, octet Two must be between 0 and 255.";
  }
  
  if ($first_octet < 1 <=> $first_octet >= 256) {
  $ip_test = "false";
  $num_msg = "It failed on the first octet, octet one must be between 1 and 255.";
  }
  
  
  }
  
  if ($ip_test eq "false") {
  print "
  $user_ip, this ip address is not valid
  ";
  print $num_msg,"
  ",$letter_msg,"
  ";
  }
  else {
  print "
  $user_ip, this ip address is a valid address
  ";
  }
  
  
• KevinADC

  November 2005

  [b][red]This message was edited by KevinADC at 2005-11-12 17:45:7[/red][/b][hr]
  your code that you posted has:
  
  if(){
  }
  if(){
  }
  if(){
  }
  else {
  }
  
  when you probably meant to use:
  
  if(){
  }
  elsif(){
  }
  elsif(){
  }
  else{
  }
  
  which makes it one continuous block of related conditions.
  
  Since it's a school assignment I don't want to just post the exact code you need based on the code you posted, but take a look at using a if/elsif/else block
  
  
  
• White_Shadow

  November 2005

  [b][red]This message was edited by White_Shadow at 2005-11-12 18:12:14[/red][/b][hr]
  yeah i know bout elsif statement jus makes it tider doesn't, it still works the same either way cause u dont need an else for every if, its working atm jus i cant figure the @ARGV function out. i know why it wasnt workin b4 it was because i had use copy and paste and the if statments were the same so it only test the one octet!!! LOL simple mistake i thought it was something worse!!
  
  well if u know how to get the @ARGV function to work it would be great. this is only question 1 of 6 i have to do LOL should get em done by monday (i hope) i got till 8 pm monday Australian time to email the scripts in.
  
  i know its an assignment and i dont want u to post the script for the solution just some hints and tips is very much apprieciated!! thanks for ya input i will prolly tidy it up with the elsif statements when i get the @ARGV function working!!!
  
  thanks for all ya commments