MrPigeon
Australia

Hey guys, just going to start off by saying I'm rather new to C. My problem is that I wrote this program for uni homework, but instead of getting eleven results printed out, I only get one. For instance:

a = 0.00; b = 1.00; c = 4.00; d = -6.00; e = 3.00; guess = 10.00

After 50 iterations ..... Root not found, method did not converge.

I was wondering whether anyone would be kind enough to give me advice on what I'm doing wrong?

P.S. Sorry, I tried to format it better, but I have no idea how to make my code look nice on this page.

int main(void) {

```
size_t counter=0;
double valueA=0.0,
valueB=1.0,
valueC=4.0,
valueD=-6.0,
valueE=3,
initialGuess=0.0,
guess=0.0,
guessNext=0.0,
polynomial=0.0,
derivative=0.0;
//Initial Guess is set to -10.0 and will increment in steps of 2.0 each time the loop is iterated until
//the initial guess is set to 10.0 and eleven results have been produced
for (initialGuess = -10.0; initialGuess <= 10.0; initialGuess += 2.0); {
guess = initialGuess; //Guess is set to initialGuess so that it can be modified while still being able to display the value of initialGuess
//Calculate the 4th order polynomial
polynomial = (pow((valueA * guess), 4)) + (pow((valueB * guess), 3)) + (pow((valueC * guess), 2)) + (valueD * guess) + (valueE);
//If the polynomial calculation is within the range of 0 and 0.000005, then the initial guess
//has stumbled on a root of the polynomial.
if (polynomial >= 0.0 && polynomial <= TOLERANCE) {
printf("a = %.2f; b = %.2f; c = %.2f; d = %.2f; e = %.2f; guess = %.2f", valueA, valueB, valueC, valueD, valueE, initialGuess);
printf("\n");
printf("Gives F(x) = %f at x = %f ..... Root found after 0 iterations.", polynomial, initialGuess);
printf("\n");
} else {
//If the polynomial calculation is greater than 0.000005, calculate the derivative of the polynomial
derivative = (pow((4 * valueA * guess), 3)) + (pow((3 * valueB * guess), 2)) + (2 * valueC * guess) + (valueD);
//If the derivative is within the range of 0 and 0.000005, Newton's method will not converge
//as you can't divide by 0 and multiplying a number by a very small number will result in a very large number
if (derivative >= 0 && derivative <= TOLERANCE) {
printf("a = %.2f; b = %.2f; c = %.2f; d = %.2f; e = %.2f; guess = %.2f", valueA, valueB, valueC, valueD, valueE, initialGuess);
printf("\n");
printf("Root not found - derivative value leads to a divergent result.");
printf("\n");
}
//Iterates Newton's method 50 times
for (counter = 0; counter < 50; counter++) {
//Calculate Newton's method to get the next guess and set the old guess to it.
guessNext = guess - (polynomial / derivative);
guess = guessNext;
//Calculate the new polynomial and derivative
polynomial = (pow((valueA * guess), 4)) + (pow((valueB * guess), 3)) + (pow((valueC * guess), 2)) + (valueD * guess) + (valueE);
derivative = (pow((4 * valueA * guess), 3)) + (pow((3 * valueB * guess), 2)) + (2 * valueC * guess) + (valueD);
//Check for the same conditions previously
if (polynomial >= 0.0 && polynomial <= TOLERANCE) {
printf("a = %.2f; b = %.2f; c = %.2f; d = %.2f; e = %.2f; guess = %.2f", valueA, valueB, valueC, valueD, valueE, initialGuess);
printf("\n");
printf("Gives F(x) = %f at x = %f ..... Root found after 0 iterations.", polynomial, initialGuess);
printf("\n");
} else if (derivative >= 0 && derivative <= TOLERANCE) {
printf("a = %.2f; b = %.2f; c = %.2f; d = %.2f; e = %.2f; guess = %.2f", valueA, valueB, valueC, valueD, valueE, initialGuess);
printf("\n");
printf("Root not found - derivative value leads to a divergent result.");
printf("\n");
}
}
//If the loop has iterated 50 times, it is assumed that the next guess cycled between the same region
//and that the method did not converge
if (counter == 50) {
printf("a = %.2f; b = %.2f; c = %.2f; d = %.2f; e = %.2f; guess = %.2f", valueA, valueB, valueC, valueD, valueE, initialGuess);
printf("\n");
printf("After 50 iterations ..... Root not found, method did not converge.");
printf("\n");
}
}
}
```

return 0;

}

It looks like you're new here. If you want to get involved, click one of these buttons!

- 140.8K All Categories
- 103.6K Programming Languages
- 6.4K Assembler Developer
- 401 Assembly Code Share
- 239 Getting started in assembly
- 4.6K x86 Assembly
- 1.9K Basic
- 97 Qbasic
- 39.9K C and C++
- 5.6K Beginner C/C++
- 330 C/C++ on Linux/Unix
- 450 C/C++ Windows API
- 522 C++ Builder
- 253 C++ Game Development
- 3.3K C++ MFC
- 103 C++.NET
- 404 Visual C++
- 2.9K C#
- 7.9K Delphi and Kylix
- 334 Advanced Delphi
- 360 Delphi beginners
- 4 Haskell
- 9.7K Java
- 56 Enterprise JavaBeans
- 1.3K Java Beginners
- 304 Java Server Pages
- 4.1K Pascal
- 1.3K Perl
- 11 Perl 6
- 2K PHP
- 546 Python
- 37 Ruby
- 4.4K VB.NET
- 258 Advanced VB.Net
- 1.6K VBA
- 20.9K Visual Basic
- 767 Access databases and VB
- 831 Advance Visual Basic
- 1.2K Beginner VB
- 2.6K Game programming
- 315 Console programming
- 90 DirectX Game dev
- 1 Minecraft
- 112 Newbie Game Programmers
- 2 Oculus Rift
- 9K Applications
- 1.8K Computer Graphics
- 279 3D Graphics
- 129 DirectX
- 125 OpenGL
- 740 Computer Hardware
- 9 Cooling & Overclocking
- 3.4K Database & SQL
- 1.1K Access
- 91 ADO Programming
- 288 MySQL
- 358 Oracle
- 440 SQL-Server
- 535 Electronics development
- 1.6K Matlab
- 628 Sound & Music
- 25 DirectSound
- 257 XML Development
- 3.3K Classifieds
- 200 Co-operative Projects
- 198 For sale
- 190 FreeLance Software City
- 1.9K Jobs Available
- 603 Jobs Wanted
- 209 Wanted
- 2.9K Microsoft .NET
- 1.8K ASP.NET
- 1.1K .NET General
- 22 .NET WEB-Services
- 129 .NET WinForms
- 14 .NET XML
- 50 ADO.NET
- 142 C# & VB.NET School Support
- 3.4K Miscellaneous
- 4 Join the Team
- 354 Comments on this site
- 69 Computer Emulators
- 2.1K General programming
- 187 New programming languages
- 621 Off topic board
- 200 Mobile & Wireless
- 72 Android
- 126 Palm Pilot
- 338 Multimedia
- 154 Demo programming
- 184 MP3 programming
- 0 Bash scripts
- 27 Cloud Computing
- 1 Witsbits Go Cloud
- 53 FreeBSD
- 1.7K LINUX programming
- 1 Awk scripting
- 332 Linux Support
- 0 Sed scripting
- 370 MS-DOS
- 0 Shell scripting
- 321 Windows CE & Pocket PC
- 4.1K Windows programming
- 177 COM/DCOM
- 61 Networking And Security
- 17 Windows 2003 Server
- 6 Windows Vista
- 176 Windows XP
- 940 Software Development
- 417 Algorithms
- 68 Object Orientation
- 24 RUP & UML
- 91 Project Management
- 95 Quality & Testing
- 268 Security
- 63 Evil Scripting
- 81 Hacking
- 7.7K WEB-Development
- 1.8K Active Server Pages
- 61 AJAX
- 4 Bootstrap Themes
- 55 CGI Development
- 28 ColdFusion
- 224 Flash development
- 1.4K HTML & WEB-Design
- 1.4K Internet Development
- 131 Mobile Internet & Messaging
- 211 Wireless development
- 2.2K JavaScript
- 37 JQuery
- 304 WEB Servers
- 153 Apache
- 79 IIS
- 150 WEB-Services / SOAP

## Comments

@tienkhoanguyen Ah thank you for responding My problem wasn't so much with the maths as it was with the for loop only printing one result instead of eleven. I've modified it from a for loop to a while loop and it seems to be functioning properly now.

Sorry to double post, but I just realised that I had a semicolon after my for loop. I'm an idiot..

Haha thanks. I've learnt java before. And I'm doing C++ as well this semester, so C feels familiar but at the same time rather strange and archaic.