#### Howdy, Stranger!

It looks like you're new here. If you want to get involved, click one of these buttons!

#### Categories

We have migrated to a new platform! Please note that you will need to reset your password to log in (your credentials are still in-tact though). Please contact lee@programmersheaven.com if you have questions.
Welcome to the new platform of Programmer's Heaven! We apologize for the inconvenience caused, if you visited us from a broken link of the previous version. The main reason to move to a new platform is to provide more effective and collaborative experience to you all. Please feel free to experience the new platform and use its exciting features. Contact us for any issue that you need to get clarified. We are more than happy to help you.

# ERROR: Not all code paths return a vale

Posts: 2Member
in C#
the error is CalculateScore, BTW I'm a newbie in C#. this is a method from a game I'm working on. MasterMind.

public static long CalculateScore(byte chances, long millisec)
{
int score;
byte num1 = chances++;
byte num2 = (byte)10;
byte num3 = (byte)10;
switch (Program.currLevelIndex)
{
case (byte)7:
num2 = (byte)10;
break;
case (byte)11:
num2 = (byte)20;
break;
case (byte)15:
num2 = (byte)40;
break;
}

if ((int)chances >= 1 && (int)chances <= 3)
num1 = (byte)40;
else if ((int)chances >= 4 && (int)chances <= 6)
num1 = (byte)20;
else if ((int)chances > 7)
num1 = (byte)10;
if (millisec > 480000L)
num3 = (byte)10;
else if (millisec >= 240000L && millisec <= 480000L)
num3 = (byte)20;
else if (millisec < 240000L)
num3 = (byte)40;
try
{
score = Convert.ToInt32((int)num2 * (int)num1 * (int)num3);
}
catch (Exception ex)
{
score = 0;
}

Console.Clear();

Console.SetCursorPosition(Program.x, Program.y);
Console.Write("Your Score was: " + score);
}
· ·

• Posts: 15Member
Hi,

I must admit that I am unable to fully comprehend your code, since you did not include the Main method, and it looks somewhat scanty.

Looking at the signature of your method i.e.,

[code]public static long CalculateScore(byte chances, long millisec) [/code]

it is clear that all paths through the method must return a value of type long.

Please check the code to ensure all if-else, switch-case or other conditional statements always result in the method returning a value of type long.

Hope it helps.

Edward
· ·
• Posts: 15Member
Hi,

I must admit that I am unable to fully comprehend your code, since you did not include the Main method, and it looks somewhat scanty.

Looking at the signature of your method i.e.,

[code]public static long CalculateScore(byte chances, long millisec) [/code]

it is clear that all paths through the method must return a value of type long.

Please check the code to ensure all if-else, switch-case or other conditional statements always result in the method returning a value of type long.

Hope it helps.

Edward
· ·
• Posts: 15Member
Hi,

I must admit that I am unable to fully comprehend your code, since you did not include the Main method, and it looks somewhat scanty.

Looking at the signature of your method i.e.,

[code]public static long CalculateScore(byte chances, long millisec) [/code]

it is clear that all paths through the method must return a value of type long.

Please check the code to ensure all if-else, switch-case or other conditional statements always result in the method returning a value of type long.

Hope it helps.

Edward
· ·
• Posts: 7Member
· ·